--

I recently refactored a button component to support an href prop and output an anchor link instead of a button. The work took me 8 hours, and I made 36 commits that touched 32 files.

There wasn't any logical way to make that a smaller PR unless I wanted to split every 12 commits into 3 separate PRs.

But, touching so many files, I could have introduced a lot of bugs. It's much better for the team to know exactly what I was doing in each commit than just "support href prop."

I do agree, though, that small PRs get reviewed while big PRs get approved.

--

--

Dr. Derek Austin 🥳
Dr. Derek Austin 🥳

Written by Dr. Derek Austin 🥳

Hi, I'm Doctor Derek! I've been a professional web developer since 2005, and I love writing about programming with JavaScript, TypeScript, React, Next.js & Git.

No responses yet